Skip to content

feat: ClientConnectionManager to manage multiple sessions without async with #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: ClientConnectionManager to manage multiple sessions without async with #1133

wants to merge 2 commits into from
+571 −0

Conversation

hanhan1123
Copy link

@hanhan1123 hanhan1123 commented Jul 12, 2025 •
edited
Loading

This PR introduces a ClientConnectionManager that allows users to manage multiple sessions without needing to explicitly use async with. This provides more flexibility in long-running or dynamic session use cases.
This PR also resolves #922 by allowing users to manage multiple sessions without async with

Motivation and Context

In developing AI agents, the MCP client is often just one part of a larger system. However, the requirement to use async with when initiating sessions makes it difficult to integrate MCP into more complex workflows, especially when other asynchronous components are involved.

To address this, I implemented a ClientConnectionManager that completely removes the need for async with during usage. This provides much greater flexibility in designing and structuring other components, particularly in long-running or modular systems.

How Has This Been Tested?

Code branches are covered via pytest unit tests.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@hanhan1123 hanhan1123 changed the title feat: add client connection manager to manage multiple sessions witho… feat: ClientConnectionManager to manage multiple sessions without async with Jul 12, 2025
@ihrpr
Copy link
Contributor

ihrpr commented Jul 15, 2025

Thank you for your contribution. The issue mentioned is related to ClientSessionGroup. If there is a specific concern around it, we need to address it in ClientSessionGroup. Adding an additional, very similar abstraction creates API fragmentation and maintenance burden.

@ihrpr ihrpr closed this Jul 15, 2025
@hanhan1123
Copy link
Author

@ihrpr
Thank you for the feedback.

Regarding ClientSessionGroup, I’ve evaluated it before proposing this PR. However, it doesn’t fundamentally resolve the session management problem.

ClientSessionGroup still relies on the async with lifecycle, which makes it tricky when you need sessions to persist across a wider application scope. More importantly, it can still hit this error:
RuntimeError: Attempted to exit cancel scope in a different task than it was entered in

And with the current architecture, there’s really no clean way to solve that, because of how async context managers and cancellation scopes work across tasks. That’s why I explored a different approach in this PR.

I’m happy to further discuss how this could evolve to better align with the project’s direction while effectively addressing these session lifecycle constraints.

@hanhan1123 hanhan1123 mentioned this pull request Jul 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create and Close multiple client session result "RuntimeError: Attempted to exit a cancel scope that isn't the current tasks's current cancel scope"
2 participants
@hanhan1123 @ihrpr